Project

General

Profile

Actions

Task #2008

closed

Delete deprecated Command Interest functions

Added by Junxiao Shi over 9 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Management
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

Command Interests is deprecated in favor of SignedInterest.

This Task is to delete deprecated types and functions including:

  • ControlCommand::makeCommandInterest
  • CommandInterestGenerator
  • CommandInterestValidator

Since Jun 2015, part of SignedInterest is split to CommandInterest, but this is distinct from the old Command Interests.

Actions #1

Updated by Junxiao Shi over 9 years ago

  • Assignee set to Junxiao Shi
  • Priority changed from Low to Normal
Actions #2

Updated by Junxiao Shi over 9 years ago

  • Blocks Task #2039: Controller: remote prefix registration added
Actions #3

Updated by Junxiao Shi over 9 years ago

  • Status changed from New to In Progress

Given that ControlCommand::makeCommandInterest is for internal use only, I'll make a backwards-incompatible change.

Actions #4

Updated by Junxiao Shi over 9 years ago

  • Subject changed from ControlCommand: rename Command Interest to Signed Interest to Delete deprecated Command Interest functions
  • Description updated (diff)
  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100

I notice that ControlCommand::makeCommandInterest is already deprecated and is not used by ndn::nfd::Controller.
Thus I'll go ahead to delete this and other command Interest stuff.

This Task also corrects a few documentation items and test cases where "command Interest" is referred to.

Actions #5

Updated by Junxiao Shi over 9 years ago

  • Blocked by Bug #2063: CommandValidator uses deprecated CommandInterestValidator added
Actions #6

Updated by Junxiao Shi over 9 years ago

  • Status changed from Code review to In Progress
  • % Done changed from 100 to 40

Unfortunately NFD compilation would be broken if Command Interest is completely deleted due to Bug #2063.

Therefore, Change I54c1b579cfb18c7662c20de40193be5543286841 only deletes ControlCommand::makeCommandInterest, which relieves unnecessary burden on #2039.

"Blocks #2039" relation can be removed after this Change is merged.

After #2063 is fixed, another Change would delete CommandInterestGenerator and CommandInterestValidator.

Actions #7

Updated by Junxiao Shi over 9 years ago

  • Blocks deleted (Task #2039: Controller: remote prefix registration)
Actions #8

Updated by Junxiao Shi almost 9 years ago

  • Description updated (diff)
Actions #9

Updated by Alex Afanasyev over 8 years ago

  • Target version changed from v0.3 to v0.4
Actions #10

Updated by Alex Afanasyev over 8 years ago

  • Target version changed from v0.4 to v0.5
Actions #11

Updated by Junxiao Shi over 7 years ago

https://gerrit.named-data.net/3124 deletes CommandInterestGenerator and ndn::util::CommandInterestValidator.
This cannot merge until #2063 closes.

Actions #12

Updated by Junxiao Shi over 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 100

repo-ng has one usage of CommandInterestGenerator. It's replaced in https://gerrit.named-data.net/3125.

Actions #13

Updated by Junxiao Shi over 7 years ago

NFD and repo-ng has been patched corrected, and other projects are unaffected https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/154426434

Notice is sent to ndn-lib nfd-dev with deadline Aug 27.

Actions #14

Updated by Junxiao Shi over 7 years ago

  • Blocked by deleted (Bug #2063: CommandValidator uses deprecated CommandInterestValidator)
Actions #15

Updated by Junxiao Shi over 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF