Project

General

Profile

Actions

Feature #2090

closed

Partial Name comparison

Added by Alex Afanasyev over 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Base
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

This task is to match Name::compare with std::string::compare (for partial name comparison):

class Name
{
public:
  /** \brief indicates "until the end" in getSubName and compare
   */
  static const size_t npos;

  /** \brief compares [pos1 ,pos1+count1) components in this Name to all components in \p other
   *
   *  This is equivalent to this->getSubName(pos1, count1).compare(other);
   */
  int
  compare(size_t pos1, size_t count1, const Name& other);

  /** \brief compares [pos1, pos1+count1) components in this Name to [pos2, pos2+count2) components in \p other
   *
   *  This is equivalent to this->getSubName(pos1, count1).compare(other.getSubName(pos2, count2));
   */
  int
  compare(size_t pos1, size_t count1, const Name& other, size_t pos2, size_t count2 = npos);
}
Actions #1

Updated by Junxiao Shi over 9 years ago

  • Tracker changed from Task to Feature
  • Subject changed from Name should have more overloads of compare to Partial Name comparison
  • Description updated (diff)
  • Estimated time set to 2.00 h

I agree with the necessity of this Feature.
With this Feature, there's opportunity of improving ContentStore and PIT performance.

I'm unsure with the necessity of name::Component partial comparison.

Actions #2

Updated by Junxiao Shi over 9 years ago

  • Description updated (diff)
  • Target version set to v0.3
Actions #3

Updated by Junxiao Shi about 9 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
Actions #4

Updated by Junxiao Shi about 9 years ago

  • Description updated (diff)

http://gerrit.named-data.net/1664

Header changes and test cases are checked in. I'll do implementation after headers are reviewed.

Actions #5

Updated by Junxiao Shi about 9 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions #6

Updated by Junxiao Shi about 9 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF