Project

General

Profile

Actions
Copy link

Feature #2295

closed

Scheduler: ScopedEventId

Added by Junxiao Shi over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Junxiao Shi
Category:
Core
Target version:
v0.3
Start date:
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

Develop a ScopedEventId type which stores an EventId and cancels it upon destruction.

  • ScopedEventId is default constructible; it doesn't contain an EventId when default constructed
  • ScopedEventId is implicitly constructible from EventId
  • ScopedEventId is assignable from EventId
  • when ScopedEventId is destructed, the EventId it holds is cancelled
  • when a different EventId is assigned to ScopedEventId, the EventId it previously holds is cancelled
  • ScopedEventId is noncopyable
  • ScopedEventId is moveable

Related issues 1 (0 open — 1 closed)

Blocks NFD - Feature #1999: Strategy for access routerClosedJunxiao Shi

Actions
Actions
Copy link
 #1

Updated by Junxiao Shi over 9 years ago

Actions
Copy link
 #2

Updated by Junxiao Shi over 9 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Davide Pesavento over 9 years ago

Sounds good to me.

Actions
Copy link
 #4

Updated by Junxiao Shi over 9 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Junxiao Shi over 9 years ago

  • Project changed from ndn-cxx to NFD
  • Category changed from Utils to Core
  • Target version changed from v0.3 to v0.3

I quickly realize that this Feature is unfeasible in ndn-cxx, because EventId does not reference Scheduler, and Scheduler is not global.

Therefore, I'll implement this in NFD, given that it's only used in NFD strategy.

Actions
Copy link
 #6

Updated by Junxiao Shi over 9 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Alex Afanasyev over 9 years ago

I could be ok with embedding reference to scheduler within ndn-cxx and then adding ScopedEventId. I'm thinking about just reference, without any guarantee for scheduler lifetime (i.e., if scheduler is destroyed before EventId, this should cause segfault).

Actions
Copy link
 #8

Updated by Junxiao Shi over 9 years ago

I could be ok with embedding reference to scheduler within ndn-cxx and then adding ScopedEventId. I'm thinking about just reference, without any guarantee for scheduler lifetime (i.e., if scheduler is destroyed before EventId, this should cause segfault).

I don't want to do that now because it's not needed.

It could be a separate Feature, after which nfd::scheduler::ScopedEventId could import from.

Actions
Copy link
 #9

Updated by Junxiao Shi over 9 years ago

  • Status changed from Code review to Closed
Actions
Copy link

Also available in: Atom PDF