Task #2350
closed
NotificationSubscriber: use Signal
100%
Description
In NotificationSubscriber, replace EventEmitter usage with Signal.
Updated by Junxiao Shi about 9 years ago
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
Updated by Junxiao Shi about 9 years ago
- % Done changed from 0 to 80
http://gerrit.named-data.net/1652
Notice is sent to ndn-lib nfd-dev.
No deadline is given because all changes must be merged at the same time.
Updated by Junxiao Shi about 9 years ago
NFD and NLSR are affected https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/47715465.
I'll defer the fixes until after #2254 closes, so that I don't have to repeat the fix on two branches.
Updated by Junxiao Shi about 9 years ago
Thanks @Vince for making the fix for NLSR http://gerrit.named-data.net/1656
One less thing to worry for me.
Updated by Junxiao Shi about 9 years ago
http://gerrit.named-data.net/1667 fixes NFD.
Changes for ndn-cxx NFD NLSR must be merged together.
Updated by Junxiao Shi about 9 years ago
- Status changed from In Progress to Code review
- % Done changed from 80 to 100
Updated by Alex Afanasyev about 9 years ago
There still be a time window when NFD/NLSR compilation will break: ndn-cxx needs to be merged first and then NFD and NLSR needs to get re-tested using the updated version of the library.
Updated by Junxiao Shi about 9 years ago
There still be a time window when NFD/NLSR compilation will break: ndn-cxx needs to be merged first and then NFD and NLSR needs to get re-tested using the updated version of the library.
I understand. As discussed in 20141128 conference call, it's unfeasible to require every ndn-cxx Change to be backwards-compatible.
I have added Breaks marks to the COMMIT_MSG of this Change.
Updated by Junxiao Shi about 9 years ago
- Status changed from Code review to Closed