Project

General

Profile

Actions

Bug #2725

closed

Potential name construction errors

Added by Alex Afanasyev about 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Normal
Category:
Base
Target version:
Start date:
04/03/2015
Due date:
% Done:

100%

Estimated time:

Description

During construction of the Name object from URI, the following logic applies:

  • "empty" name components are skipped
  • for each name component in URI, heading and trailing whitespace is stripped

The first issue was working properly due to a bug in name::Component implementation, fixed as part of #2660. I believe that URIs containing multiple / in sequence are invalid and should throw exception (e.g., /hello////world should be invalid). After #2660, behavior changes to throw exception.

I'm not sure if the second logic is correct. In other words, why / hello\t/\tworld \r\n is equivalent to /hello/world ?


Related issues 1 (1 open0 closed)

Related to ndn-cxx - Feature #1840: Make ndn URI resolution RFC3986-compliantNew

Actions
Actions #1

Updated by Alex Afanasyev about 9 years ago

  • Description updated (diff)
Actions #2

Updated by Junxiao Shi about 9 years ago

  • Related to Feature #1840: Make ndn URI resolution RFC3986-compliant added
Actions #3

Updated by Junxiao Shi about 9 years ago

As said in http://www.lists.cs.ucla.edu/pipermail/nfd-dev/2014-August/000313.html:

My opinion is that this feature should be implemented only when somebody actually needs it. Until then, there is no point of spending time on it.

If there isn't "somebody actually needs it", don't change the behavior. Otherwise, do it properly as #1840.

Actions #4

Updated by Alex Afanasyev about 9 years ago

ok

Actions #5

Updated by Junxiao Shi about 9 years ago

  • Status changed from Code review to Closed
  • Assignee set to Alex Afanasyev
  • % Done changed from 50 to 100
Actions

Also available in: Atom PDF