Bug #3011: BroadcastStrategy: strategy name is confusing - NFD - NDN project issue tracking system

Actions

Copy link

Bug #3011

closed

BroadcastStrategy: strategy name is confusing

Added by Junxiao Shi almost 9 years ago. Updated over 8 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Junxiao Shi

Category:

Forwarding

Target version:

v0.4

Start date:

07/03/2015

Due date:

% Done:

100%

Estimated time:

2.00 h

Description

The broadcast strategy forwards Interests to all nexthops listed in the FIB entry.

This differs from the common understanding of the term broadcast which is expected to forward Interests to all faces even if they are not in the FIB entry.

Therefore, this strategy should be renamed as multicast strategy.

Files

Download all files

email.pdf (39.7 KB) email.pdf		Spyros Mastorakis, 07/07/2015 09:33 PM
20150828170427-2.tgz (151 KB) 20150828170427-2.tgz	integ 2403,1	Junxiao Shi, 08/28/2015 11:06 AM

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Spyros Mastorakis almost 9 years ago

What is the target version for this bug? Should I assign it to myself and fix it?

Actions

Copy link

Updated by Junxiao Shi almost 9 years ago

This issue is waiting on Lixia to provide evidence that proves the confusion.

No target version will be set until the proof is in place.

Actions

Copy link

Updated by Spyros Mastorakis almost 9 years ago

I can provide some emails of ndnSIM users having been confused because of that. Actually, I received the last one some days before.

Actions

Copy link

Updated by Junxiao Shi almost 9 years ago

Please post the mailing list links, or attach PDFs to this issue. Two complaints shall be enough.

After that, we can set target version, and make a plan on how to do a backwards-compatible change.

Actions

Copy link

Updated by Spyros Mastorakis almost 9 years ago

File email.pdf email.pdf added

This is the most recent related email I received. I will need some time to search the ndnSIM mailing list for a second one.

Actions

Copy link

Updated by Junxiao Shi almost 9 years ago

Reply to note-5: I'll wait for a second complaint before believe the confusion is widespread.

I want to point out that commenting out if (pitEntry->canForwardTo(*outFace)) does not turn the strategy into "pure broadcast" (ie. sending Interest to all faces even if there's no FIB nexthop record).
The strategy is still constrained among FIB nexthop records.
This modification would allow consumer retransmission Interests to go out of all faces listed in FIB nexthop records again, even if the out-record is unexpired.

In fact, "pure broadcast" is unfeasible under current strategy API, but I intend to solve this problem in #2000.

Actions

Copy link

Updated by Spyros Mastorakis over 8 years ago

As we discussed in NFD call 08032015, I talked with two graduate students from the Mobility First project team during the recent FIA Project meeting at MIT. Both of them had looked our codebase and asked me why we broadcast the Interests.

Actions

Copy link

Updated by Junxiao Shi over 8 years ago

Assignee set to Junxiao Shi
Target version set to v0.4

note-5 and note-7 give sufficient evidence to proceed with this issue.

I'll design the transition plan.

Actions

Copy link

Updated by Junxiao Shi over 8 years ago

Status changed from New to In Progress

Design:

NFD code changes:

* Rename `BroadcastStrategy` class to `MulticastStrategy`, and change StrategyName to `ndn:/localhost/nfd/strategy/multicast/%FD%01`.
* Update all unit test cases to refer to `MulticastStrategy`.
* Create `BroadcastStrategy` class that inherits from `MulticastStrategy`, and overrides StrategyName to `ndn:/localhost/nfd/strategy/broadcast/%FD%01`.

Update NFD Developer Guide to refer to "multicast strategy".
Update IntegrationTests to use ndn:/localhost/nfd/strategy/multicast.
Send notification to nfd-dev and operators mailing lists.
Delete BroadcastStrategy class at next release.

Actions

Copy link

#10

Updated by Junxiao Shi over 8 years ago

20150810 conference call approves the design in note-9.

Actions

Copy link

#11

Updated by Junxiao Shi over 8 years ago

% Done changed from 0 to 20

NFD code changes: http://gerrit.named-data.net/2366

Actions

Copy link

#12

Updated by Junxiao Shi over 8 years ago

Reviewer has pointed out that commit:1d470df0da0467dae7888c5474eea134c0a8a533 is missing updates in "nfd.conf.sample.in" and "documentation that references broadcast strategy".

I have identified the following places in NFD repository that references "broadcast":

daemon/fw/broadcast-strategy.hpp and its implementation and test suite: intentional, for backwards compatibility
nfd.conf.sample.in and daemon/mgmt/tables-config-section.cpp: should be updated
tools/ndn-autoconfig/multicast-discovery.cpp: should be updated
docs/manpages/nfdc.rst: should be updated
docs/RELEASE_NOTES.rst: do not update, to preserve history

Actions

Copy link

#13