Project

General

Profile

Actions

Feature #3463

closed

dump: recognize Nack

Added by Junxiao Shi about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

In ndndump, recognize Nack packets.

The output should contain at least: Nack reason, Interest name, Nonce.


Files

nack-capture.pcap (1.98 KB) nack-capture.pcap ndndump NACK test pcap file Vince Lehman, 02/29/2016 10:34 AM
Actions #1

Updated by Vince Lehman about 8 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 90
Actions #2

Updated by Junxiao Shi about 8 years ago

How is this tool tested beyond unit testing?

Can the assignee upload pcap files that contain Nack packets under different underlying protocols?
At least two Nack reasons plus reasonless Nack, and at least two underlying protocols should be included.

Actions #4

Updated by Junxiao Shi about 8 years ago

I confirm note-3 trace fulfills the requirements in note-2.

I notice that ndndump in ndn-tools:commit:589474aff39edb36b747e109d893e99187b41dc2 prints many lines of Tunnel Type: TCP, INCOMPLETE-PACKET, size: 0.
Correlating the timestamps in Wireshark, those packets are TCP ACKs without payload.
It's incorrect to label a TCP packet without payload as "INCOMPLETE" because there's no NDN packet at all; I suggest skipping them without printing anything.

Other than the above problem, Nacks are parsed correctly.

Actions #5

Updated by Junxiao Shi about 8 years ago

  • Status changed from Code review to Feedback

ndndump manpage and tools/dump/README.md should be updated to reflect the new capability.

Actions #6

Updated by Junxiao Shi about 8 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF