Project

General

Profile

Actions

Feature #3653

closed

Controller: response validation

Added by Junxiao Shi almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Management
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

Use a Validator to validate response Data to ControlCommand and StatusDataset, and fail the operation if validation fails.

Controller should accept a Validator& parameter.

The default shall be an internal ValidatorNull instance for backwards compatibility.


Related issues 1 (0 open1 closed)

Blocked by ndn-cxx - Feature #3329: Controller: client for StatusDatasetClosedJunxiao Shi

Actions
Actions #1

Updated by Junxiao Shi almost 8 years ago

  • Blocked by Feature #3329: Controller: client for StatusDataset added
Actions #2

Updated by Junxiao Shi over 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • Target version set to v0.5

I'll work on this issue in two commits:

  1. accept Validator& parameter, and call validator for StatusDataset; this satisfies immediate needs for #3658
  2. call validator for ControlCommand
Actions #3

Updated by Junxiao Shi over 7 years ago

  • % Done changed from 0 to 50

https://gerrit.named-data.net/2914 accepts Validator on Controller constructor, and adds a test case for StatusDataset response validation.

Actions #4

Updated by Junxiao Shi over 7 years ago

https://gerrit.named-data.net/2914 patchset6 abstracts the validator used in test suite as DummyValidator so it can be reused in other test suites.

Actions #5

Updated by Junxiao Shi over 7 years ago

  • % Done changed from 50 to 60

Before I could add validation to ControlCommand functionality, I notice there's inconsistency between how empty failure callbacks are handled.

https://gerrit.named-data.net/2943 fixes the problem, and also reorders existing test cases.

Actions #6

Updated by Junxiao Shi over 7 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 60 to 100

https://gerrit.named-data.net/3044 implements ControlCommand response validation.

Actions #7

Updated by Junxiao Shi over 7 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF