Project

General

Profile

Actions

Task #3870

closed

Use SIGQUIT instead of SIGINT

Added by Ashlesh Gawande almost 8 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
12/01/2016
Due date:
% Done:

100%

Estimated time:

Description

Use SIGQUIT (control+ \) instead of SIGINT because control+c is used to kill programs such as ndnpingserver


Related issues 1 (0 open1 closed)

Related to mini-ndn - Task #3672: Mini-NDN must exit gracefully if NLSR is not covergedClosed07/14/2016

Actions
Actions #1

Updated by Ashlesh Gawande almost 8 years ago

  • Related to Task #3672: Mini-NDN must exit gracefully if NLSR is not coverged added
Actions #2

Updated by Ashlesh Gawande almost 8 years ago

  • Description updated (diff)
Actions #3

Updated by Ashlesh Gawande about 7 years ago

  • Assignee changed from Ashlesh Gawande to Damian Coomes

Check if Control-C kills NFD running on the node in addition to ndnpingserver or something else running in foreground before implementing this.

Actions #4

Updated by Damian Coomes about 7 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Damian Coomes about 7 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 90
Actions #6

Updated by Ashlesh Gawande about 7 years ago

Damian, turns out the NFD receiving sigint of parent is solved by using setsid when running nfd.
Can you test this change:
https://gerrit.named-data.net/#/c/4259/
Especially test that NFD is no longer killed.
Also run the failure convergence test and make sure NFD is killed and brought up correctly.

Also, if you have time - add some documents for this. Thanks.

Actions #7

Updated by Ashlesh Gawande about 7 years ago

Nevermind, I will push to your old change - I forgot about that.

Actions #8

Updated by Damian Coomes about 7 years ago

Yeah, it looks like it is working properly. I ran minindn and checked that nfd is not killed after a SIGINT is sent to stop ndnping. Convergence and failed convergence tests both work. NFD is killed on the node that is brought down during the failed convergence test and then is restarted.

Actions #9

Updated by Damian Coomes about 7 years ago

  • Status changed from Code review to Closed
  • % Done changed from 90 to 100
Actions #10

Updated by Ashlesh Gawande about 7 years ago

  • Target version set to v0.4.0
Actions

Also available in: Atom PDF