Project

General

Profile

Actions

Task #1838

closed

Expect markers in StatusDataset and NotificationStream consumers

Added by Junxiao Shi over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tools
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

In StatusDataset consumers, expect 0xFD marker on version component, expect 0x00 marker on segment component.

In NotificationStream consumers, expect 0xFE marker on sequence number component.


Related issues 1 (0 open1 closed)

Related to NFD - Task #1837: Include markers in StatusDataset and NotificationStream publishersClosedJunxiao Shi

Actions
Actions #1

Updated by Junxiao Shi over 9 years ago

  • Related to Task #1837: Include markers in StatusDataset and NotificationStream publishers added
Actions #2

Updated by Junxiao Shi over 9 years ago

  • Status changed from New to In Progress

I determine it's more efficient to complete this Task at the same time as #1837, so these will be in one commit.

Actions #3

Updated by Junxiao Shi over 9 years ago

  • % Done changed from 0 to 60

I notice that FaceMonitor lacks unit testing. I'm adding them as part of this Task.

Actions #4

Updated by Junxiao Shi over 9 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 60 to 100

Making FaceMonitor testable is a lot of work. In this process, I also refactor this class to a generic NotificationSubscriber template.

Actions #5

Updated by Junxiao Shi over 9 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF