https://redmine.named-data.net/https://redmine.named-data.net/favicon.ico?14759811232014-10-07T01:32:48ZNDN project issue tracking systemNFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51552014-10-07T01:32:48ZJunxiao Shi
<ul></ul><p>Please provide a code snippet to reproduce this issue.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51772014-10-07T21:11:55ZTai-Lin Chutailinchu@gmail.com
<ul></ul><p>fib add-nexthop?</p>
<p>I actually find the bug. It is pretty obvious.</p>
<p><a href="https://github.com/named-data/NFD/blob/68bc1e0dce68c0a0ef98fe5e3fee15a4d8b21fc8/daemon/mgmt/fib-manager.cpp#L146">https://github.com/named-data/NFD/blob/68bc1e0dce68c0a0ef98fe5e3fee15a4d8b21fc8/daemon/mgmt/fib-manager.cpp#L146</a></p>
<p>that !parameters.hasFaceId()</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51782014-10-07T21:17:02ZJunxiao Shi
<ul><li><strong>Subject</strong> changed from <i>face id cannot be ignored</i> to <i>fib/add-nexthop: FaceId should be optional</i></li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/5178/diff?detail_id=4962">diff</a>)</li><li><strong>Category</strong> set to <i>Management</i></li><li><strong>Target version</strong> set to <i>v0.3</i></li><li><strong>Estimated time</strong> set to <i>1.00 h</i></li></ul> NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51792014-10-07T21:19:28ZTai-Lin Chutailinchu@gmail.com
<ul></ul><p><a href="https://github.com/named-data/NFD/commit/7564d97d135b3fc9bb1150cdfb7505177813f572">https://github.com/named-data/NFD/commit/7564d97d135b3fc9bb1150cdfb7505177813f572</a></p>
<p>The origin commit that introduces the bug. I guess it is not a bug back then.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51802014-10-07T21:36:37ZJunxiao Shi
<ul><li><strong>Assignee</strong> set to <i>Tai-Lin Chu</i></li></ul><p>Please cancel GitHub pull request, and submit the patch to Gerrit for review.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51812014-10-08T04:54:28ZJunxiao Shi
<ul></ul><blockquote>
<p>The face ID is optional only for self registrations, not for any other fib operations to add routes.</p>
</blockquote>
<p>No. <a class="wiki-page" href="https://redmine.named-data.net/projects/nfd/wiki/FibMgmt#Add-a-nexthop">fib/add-nexthop</a> command allows optional FaceId.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51832014-10-08T08:30:26ZLan Wanglanwang@memphis.edu
<ul></ul><p>In what situation is the optional faceID needed? If there has not been any problems so far, I assume nrd always supplies the faceID.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51842014-10-08T08:43:27ZJunxiao Shi
<ul></ul><p>The protocol allows omitting FaceId. The default value of FaceId is 0, which means "the requesting face".<br><br>
<code>nrd</code> always setting FaceId doesn't mean <code>FibManager</code> can violate protocol.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51852014-10-08T08:49:50ZLan Wanglanwang@memphis.edu
<ul></ul><p>I was asking why the protocol defines the FaceID as optional. If I understand correctly, the fib commands are issued only by nrd. Applications do not directly interact with nfd to register their prefixes, but the optional FaceID is useful only in this case.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=51862014-10-08T08:53:18ZJunxiao Shi
<ul></ul><p>The recommended way to represent "self" is omitting the FaceId field. This is consistent with other commands such as <code>faces/enable-local-control</code> and <code>rib/register</code>.<br><br>
Allowing FaceId=0 is due to historical reason.</p>
NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=52132014-10-08T14:12:21ZAlex Afanasyev
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Code review</i></li></ul> NFD - Bug #2031: fib/add-nexthop: FaceId should be optionalhttps://redmine.named-data.net/issues/2031?journal_id=53822014-10-17T08:32:14ZJunxiao Shi
<ul><li><strong>Status</strong> changed from <i>Code review</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul>