https://redmine.named-data.net/https://redmine.named-data.net/favicon.ico?14759811232015-01-04T01:07:02ZNDN project issue tracking systemNFD - Task #2298: Rename nfd::EventId to nfd::scheduler::EventIdhttps://redmine.named-data.net/issues/2298?journal_id=70622015-01-04T01:07:02ZAlex Afanasyev
<ul></ul><p>There is only one scheduler, why do you need additional association? Just "EventId" seem enough to represent that it is something about scheduled events.</p>
<p>I prefer keeping code as is. </p>
NFD - Task #2298: Rename nfd::EventId to nfd::scheduler::EventIdhttps://redmine.named-data.net/issues/2298?journal_id=70732015-01-04T15:19:08ZAlex Afanasyev
<ul><li><strong>Subject</strong> changed from <i>Eliminate nfd::EventId</i> to <i>Rename nfd::EventId to nfd::scheduler::EventId</i></li><li><strong>Estimated time</strong> changed from <i>1.50 h</i> to <i>0.50 h</i></li></ul><p>In general, I'm against pointless changes of the existing code. I agree there could be some confusion with EventEmitter, but there shouldn't be confusing with Signal and Connections.</p>
<p>If you really want to make this change, I wouldn't object.</p>
NFD - Task #2298: Rename nfd::EventId to nfd::scheduler::EventIdhttps://redmine.named-data.net/issues/2298?journal_id=70792015-01-04T17:55:10ZJunxiao Shi
<ul><li><strong>Estimated time</strong> changed from <i>0.50 h</i> to <i>1.00 h</i></li></ul><p>It's not a "pointless change". It's an improvement which makes code more readable.</p>
NFD - Task #2298: Rename nfd::EventId to nfd::scheduler::EventIdhttps://redmine.named-data.net/issues/2298?journal_id=71782015-01-08T18:58:25ZJunxiao Shi
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>Junxiao Shi</i></li></ul> NFD - Task #2298: Rename nfd::EventId to nfd::scheduler::EventIdhttps://redmine.named-data.net/issues/2298?journal_id=71792015-01-08T19:18:42ZJunxiao Shi
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Code review</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p><a href="http://gerrit.named-data.net/1609">http://gerrit.named-data.net/1609</a></p>
NFD - Task #2298: Rename nfd::EventId to nfd::scheduler::EventIdhttps://redmine.named-data.net/issues/2298?journal_id=71972015-01-09T14:05:36ZJunxiao Shi
<ul><li><strong>Status</strong> changed from <i>Code review</i> to <i>Closed</i></li></ul>