Project

General

Profile

Bug #2563

Multicast faces are reported as point-to-point

Added by Davide Pesavento over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Faces
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

nfd-status -f shows all faces, including multicast ones, as "point-to-point". IIUC multicast faces should be reported as "multi-access".

There are actually two bugs here:

  1. Face::copyStatusTo does not set the flag in FaceTraits, which therefore defaults to LINK_TYPE_POINT_TO_POINT.
  2. EthernetFace does not override isMultiAccess to return true (but MulticastUdpFace does).

History

#1 Updated by Davide Pesavento over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Davide Pesavento

I'm also wondering... isMultiAccess and isLocal are similar properties, i.e. they both indicate a trait of the face that cannot change during its lifetime (as opposed to an administrative setting that can be changed later on, such as isOnDemand). Yet they're implemented in different ways. isMultiAccess is a virtual getter method, while isLocal is a member field set via a constructor argument and with a non-virtual getter. Can we be more uniform?

#2 Updated by Alex Afanasyev over 4 years ago

I agree with Davide that we should be consistent and I like the idea of defining non-virtual getter for isMultiAccess (+ constructor argument for face classes)

#3 Updated by Davide Pesavento over 4 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 40

#4 Updated by Junxiao Shi over 4 years ago

  • Status changed from Code review to In Progress

Status shall be kept in "In Progress" until the final commit is uploaded.

#5 Updated by Davide Pesavento over 4 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 40 to 100

#6 Updated by Junxiao Shi over 4 years ago

  • Status changed from Code review to Closed

Also available in: Atom PDF