Project

General

Profile

Bug #2630

WebSocketChannel catches the wrong exceptions

Added by Davide Pesavento over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Faces
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

In several places, WebSocketChannel tries to catch an exception of type websocketpp::lib::error_code, but the correct type is websocketpp::exception.

However, instead of just fixing the catch statement, I suggest switching to the non-throwing variants of the relevant functions.

History

#1 Updated by Wentao Shang over 4 years ago

  • Assignee set to Wentao Shang

#2 Updated by Wentao Shang over 4 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 70

#3 Updated by Wentao Shang over 4 years ago

  • Status changed from Code review to Closed
  • % Done changed from 70 to 100

Also available in: Atom PDF