Project

General

Profile

Task #3098

Merge KeyChain branch

Added by Junxiao Shi over 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Security
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

Merge feature-keychain branch (since Jul 2015) into master, and perform finalization works including:

  • change throw to BOOST_THROW_EXCEPTION (#2997)
  • use make_unique (#3093)

Related issues

Related to NFD - Task #4089: Adapt to ndn-cxx v2::KeyChain and ValidatorClosed2017-05-24

Blocked by ndn-cxx - Task #2926: Refactor KeyChainClosed

Blocks ndn-tools - Feature #4205: Restore PIB service after ndn-cxx security v2 and other breaking changesNew

History

#1 Updated by Junxiao Shi over 3 years ago

#2 Updated by Junxiao Shi over 3 years ago

If a change that should be implemented in feature-keychain immediately before or after the merge, update the description of this issue to include that.

If a feature should be implemented in feature-keychain before it can merge, make that issue block this issue.

#3 Updated by Junxiao Shi over 2 years ago

#4 Updated by Alex Afanasyev over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Alex Afanasyev

#5 Updated by Junxiao Shi over 2 years ago

TravisCI OSX builds are failing due to unsuccessful OpenSSL installation.

https://travis-ci.org/named-data/ndn-cxx/jobs/149642201

https://travis-ci.org/named-data/NFD/jobs/149775487

+brew link --force openssl
Warning: Refusing to link: openssl
Linking keg-only openssl means you may end up linking against the insecure,
deprecated system OpenSSL while using the headers from Homebrew's openssl.
Instead, pass the full include/library paths to your compiler e.g.:
  -I/usr/local/opt/openssl/include -L/usr/local/opt/openssl/lib

+./waf configure -j1 --color=yes --enable-shared --disable-static --without-osx-keychain
Checking for OpenSSL lib                             : OpenSSL not found, please provide a --with-openssl=PATH argument (see help)

#6 Updated by Alex Afanasyev about 2 years ago

  • Target version changed from v0.5 to v0.6
  • % Done changed from 0 to 100
  • Estimated time deleted (3.00 h)

All code from the key-chain branch was successfully merged to master.

#7 Updated by Alex Afanasyev about 2 years ago

#8 Updated by Alex Afanasyev about 2 years ago

  • Status changed from In Progress to Closed

#9 Updated by Zhiyi Zhang over 1 year ago

  • Related to Task #4089: Adapt to ndn-cxx v2::KeyChain and Validator added

#10 Updated by Junxiao Shi over 1 year ago

  • Blocks Feature #4205: Restore PIB service after ndn-cxx security v2 and other breaking changes added

Also available in: Atom PDF