Project

General

Profile

Actions

Feature #3841

closed

localhop scope restriction in strategy

Added by Junxiao Shi over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Category:
Forwarding
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
6.00 h

Description

Implement localhop scope restriction in all strategies existing as of NFD 0.5.0 release.
Remove localhop restrictions in forwarding pipelines.


Related issues 1 (0 open1 closed)

Blocked by NFD - Feature #1756: Let strategy pick outgoing Interest packetClosedJunxiao Shi

Actions
Actions #1

Updated by Junxiao Shi over 7 years ago

  • Blocked by Feature #1756: Let strategy pick outgoing Interest packet added
Actions #2

Updated by Junxiao Shi over 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • % Done changed from 0 to 30
  • Estimated time set to 6.00 h

https://gerrit.named-data.net/3334 implements new localhop rules as a new violatesScope overload, and switches BestRouteStrategy2 to use it.
pit-algorithm.hpp is renamed as algorithm.hpp because the new overload does not operate on an Interest table entry.

Other strategies will be updated in subsequent commits.

Partial test coverage for BestRouteStrategy2 localhop scope restriction already exists in Fw/TestBestRouteStrategy2/NoRouteNack test case, so
When two or more strategies have implemented scope restriction, I'll introduce a test case template that tests scope restriction feature for all updated strategies.

Actions #3

Updated by Junxiao Shi over 7 years ago

  • % Done changed from 30 to 40

https://gerrit.named-data.net/3336 implements localhop scope in AccessStrategy. Test case template will be added in a later patchset of this Change.

Actions #4

Updated by Junxiao Shi over 7 years ago

Test cases have been added to https://gerrit.named-data.net/3336. Please review.

I plan to update most strategies myself.
I may let Ashlesh update multicast strategy to avoid conflict with #3176, and also ASF strategy since I don't have sufficient understanding with that strategy.

Actions #5

Updated by Junxiao Shi over 7 years ago

  • Assignee changed from Junxiao Shi to Ashlesh Gawande
  • % Done changed from 40 to 70

https://gerrit.named-data.net/3344 implements localhop scope in BestRouteStrategy (v1), MulticastStrategy, and NccStrategy.

This issue is now re-assigned to Ashlesh who is responsible for updating AsfStrategy. See BestRouteStrategy2 for example. Unit testing only needs one line in strategy-scope-control.t.cpp.
After that, please assign this issue back to me; then I'll delete deprecated functions in another commit, and also update documentation.

Actions #6

Updated by Junxiao Shi over 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 70 to 100

nfd-docs:commit:f7c37a25ba92d8275100e98d9eeb0b45a817076c

Actions

Also available in: Atom PDF