https://redmine.named-data.net/https://redmine.named-data.net/favicon.ico?14759811232017-06-14T07:35:01ZNDN project issue tracking systemrepo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=195052017-06-14T07:35:01ZJunxiao Shi
<ul><li><strong>Blocked by</strong> <i><a class="issue tracker-1 status-5 priority-2 priority-default closed" href="/issues/2023">Bug #2023</a>: ERROR: Failed to register prefix in local hub's daemon</i> added</li></ul> repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=200832017-07-25T14:13:23ZJunxiao Shi
<ul><li><strong>Assignee</strong> set to <i>Muktadir Chowdhury</i></li></ul><p>This is needed to reduce the direct dependency on v1 validators.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=201412017-08-03T11:48:28ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul></ul><p>I integrated dispatcher. In unit-tests, the identity management fixture uses v2::security. Unit-tests are passing with v2::security but integrated test is failing. </p>
<p>So I changed it to v1::security. Now all the tests are failing. What should I do now?</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=201422017-08-03T11:55:45ZJunxiao Shi
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-high2 closed" href="/issues/4091">Task #4091</a>: Adapt to ndn-cxx v2::KeyChain and Validator</i> added</li></ul> repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=201442017-08-03T11:57:02ZJunxiao Shi
<ul></ul><p>As I explained in 20170731 NFD call, this issue should keep using ndn-cxx v1 Validator, and specifically <code>ValidatorNull</code>. It would never pass Jenkins, but you can manually verify the build with ndn-cxx-breaks and set ndn-cxx to patchset 4050,2; you should post the build log link on Gerrit. When it's time to merge, I'll override the negative vote from Jenkins and approve the Change.</p>
<p>The switchover to v2 Validator is to be performed in <a class="issue tracker-3 status-5 priority-4 priority-high2 closed" title="Task: Adapt to ndn-cxx v2::KeyChain and Validator (Closed)" href="https://redmine.named-data.net/issues/4091">#4091</a> and needs to wait for v2 <code>ValidationPolicyConfig</code> to become ready.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=201702017-08-04T11:17:23ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul></ul><p>SInce tests/identity-management-fixture is using v2::Certificate, I am using latest ndn-cxx and it also contains ValidatorNull. But my code was breaking due to this commit ( <a href="https://github.com/named-data/ndn-cxx/commit/6938e3461bc7b64531403b05d18d492d4713c641">https://github.com/named-data/ndn-cxx/commit/6938e3461bc7b64531403b05d18d492d4713c641</a>), so changed src/storage/index.cpp to use the new name. Then everything compiles and build/unit-tests passes but integrated/ tests are failing.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=201762017-08-05T06:24:08ZJunxiao Shi
<ul></ul><p>Let me repeat: This issue is to switch to Dispatcher, while still using v1 ValidatorNull. It needs to be manually verified with ndn-cxx:commit:2dd711d0a3796a0731f7fe86aba10b8c867edb4e through ndn-cxx-breaks by entering "4050,2".</p>
<p>The reason of separation is to minimize changes in each commit, so that it's clear what changes are for dispatch and what changes are for validator.<br>
ValidatorNull completely ignores the signature so it will accept a command Interest even it's signed with another version's KeyChain.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=202032017-08-07T13:21:45ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul></ul><p>What are the optional and required parameters of RepoCommands (watch, delete, insert)? Are all the fields required for all the commands? There is no mentioning about it here <a href="https://redmine.named-data.net/projects/repo-ng/wiki/Repo_Command">https://redmine.named-data.net/projects/repo-ng/wiki/Repo_Command</a></p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=202122017-08-07T16:01:28ZJunxiao Shi
<ul></ul><blockquote>
<p>What are the optional and required parameters of RepoCommands (watch, delete, insert)? Are all the fields required for all the commands?</p>
</blockquote>
<p>They are mentioned on <a class="wiki-page" href="https://redmine.named-data.net/projects/repo-ng/wiki/Basic_Repo_Insertion_Protocol">Basic_Repo_Insertion_Protocol</a>, <a class="wiki-page" href="https://redmine.named-data.net/projects/repo-ng/wiki/Repo_Deletion_Protocol">Repo_Deletion_Protocol</a>, and <a class="wiki-page" href="https://redmine.named-data.net/projects/repo-ng/wiki/Watched_Prefix_Insertion_Protocol">Watched_Prefix_Insertion_Protocol</a> under each command.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=202432017-08-09T19:19:37ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul></ul><p>@junxiao, Since we are adopting ndn::mgmt::Dispatcher, repo::RepoCommandResponse should inherit from ndn::mgmt::ControlResponse. What do you think?</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=202602017-08-10T06:15:10ZJunxiao Shi
<ul></ul><blockquote>
<p>Since we are adopting ndn::mgmt::Dispatcher, repo::RepoCommandResponse should inherit from ndn::mgmt::ControlResponse.</p>
</blockquote>
<p>Yes, exactly.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=242122018-10-27T12:47:30Zweijia yuan
<ul></ul><p>Read handle is inherited from base handle, the others are inherited from command base handle. Read is not exactly a command that needs to be validated. The other three handle are using CommandBaseHandle:makeAuthorization() includes validator. So I think the original design is right.<br>
Or using dispatcher, we actually don't need any kind of validator in this code? In that case I can delete the makeAuthorization and make all handles inherited from command base handle.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=242132018-10-27T12:48:28Zweijia yuan
<ul></ul><p>and I have been trying to run integrated test for this change. Under which version of ndn-cxx I should use to verify the code(your previous discussion is about one year ago)?</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=242142018-10-27T12:50:31ZJunxiao Shi
<ul></ul><p>Reply to note-12: please read Dispatcher API to find the answers.</p>
<p>Reply to note-12: all tests need to pass against ndn-cxx in master branch.</p>
repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=242152018-10-27T19:31:51ZJunxiao Shi
<ul><li><strong>Blocks</strong> deleted (<i><a class="issue tracker-3 status-5 priority-4 priority-high2 closed" href="/issues/4091">Task #4091</a>: Adapt to ndn-cxx v2::KeyChain and Validator</i>)</li></ul> repo-ng - Feature #4129: Management Dispatcher for repo commandshttps://redmine.named-data.net/issues/4129?journal_id=261292019-11-05T13:22:13ZAshlesh Gawande
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-1 priority-3 priority-high3" href="/issues/4944">Bug #4944</a>: ndnputfile does not work</i> added</li></ul>