https://redmine.named-data.net/https://redmine.named-data.net/favicon.ico?14759811232018-01-08T22:54:50ZNDN project issue tracking systemndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=217382018-01-08T22:54:50ZDavide Pesavento
<ul><li><strong>Tracker</strong> changed from <i>Task</i> to <i>Feature</i></li><li><strong>Subject</strong> changed from <i>Add a signal in the segment fetcher to detect the receiving of a data segment.</i> to <i>Add a signal to SegmentFetcher to notify the reception of a Data segment</i></li><li><strong>Category</strong> set to <i>Utils</i></li><li><strong>Target version</strong> set to <i>v0.7</i></li></ul> ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=217752018-01-09T13:33:26ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default closed" href="/issues/4448">Feature #4448</a>: Serve other routers' certificates</i> added</li></ul> ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=217772018-01-09T13:33:39ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-2 status-5 priority-2 priority-default closed" href="/issues/4448">Feature #4448</a>: Serve other routers' certificates</i>)</li></ul> ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=217792018-01-09T13:34:06ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default closed" href="/issues/4448">Feature #4448</a>: Serve other routers' certificates</i> added</li></ul> ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=217982018-01-10T01:32:56ZJunxiao Shi
<ul></ul><p>For NLSR’s use case, I’d suggest an additional signal:</p>
<pre><code>Signal<SegmentFetcher, Data> afterSegmentValidated;
</code></pre>
<p>This is emitted only if the Data passes validation.</p>
ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=218262018-01-11T16:10:54ZDavide Pesavento
<ul></ul><p>I'm not against using signals in general, but the current <code>SegmentFetcher</code> API is based on callbacks. This proposal mixes callbacks and signals, and makes the API ugly and inconsistent. Any reasons we're not augmenting the API by adding more callbacks? Or alternatively, why not make the whole API signal-based? (in the latter case, existing callbacks can be deprecated and eventually removed).</p>
ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=218272018-01-11T16:12:31ZDavide Pesavento
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Code review</i></li></ul><p><a href="https://gerrit.named-data.net/4433">https://gerrit.named-data.net/4433</a></p>
ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=218282018-01-11T16:22:32ZJunxiao Shi
<ul></ul><blockquote>
<p>Any reasons we're not augmenting the API by adding more callbacks?</p>
</blockquote>
<p>There are already too many of them.</p>
<blockquote>
<p>why not make the whole API signal-based?</p>
</blockquote>
<p>I agree with this. In this case, <code>fetch</code> function shall be renamed as <code>start</code> and the function does not take any callbacks.<br>
The <code>fetch</code> function becomes deprecated.</p>
ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=218472018-01-14T10:17:50ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul></ul><p>Junxiao Shi wrote:</p>
<blockquote>
<blockquote>
<p>Any reasons we're not augmenting the API by adding more callbacks?</p>
</blockquote>
<p>There are already too many of them.</p>
<blockquote>
<p>why not make the whole API signal-based?</p>
</blockquote>
<p>I agree with this. In this case, <code>fetch</code> function shall be renamed as <code>start</code> and the function does not take any callbacks.<br>
The <code>fetch</code> function becomes deprecated.</p>
</blockquote>
<p>I think it should be in a different commit. What do you think? I can crate an issue for this.</p>
ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=218482018-01-14T12:13:09ZAlex Afanasyev
<ul></ul><p>Guys, I don't disagree with moving to signal based, but I would consider it is "beautification" that we can do later in due time. We have kind of an emergency to make this specific signal work, so let's not stall.</p>
ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=218492018-01-15T09:00:21ZMuktadir Chowdhurymrchwdhr@memphis.edu
<ul></ul><p>Created an issue <a class="issue tracker-3 status-5 priority-2 priority-default closed" title="Task: Make SegmentFetcher pure Signal-based (Closed)" href="https://redmine.named-data.net/issues/4464">#4464</a> to make SegmentFetcher Signal based.</p>
ndn-cxx - Feature #4438: Add a signal to SegmentFetcher to notify the reception of a Data segmenthttps://redmine.named-data.net/issues/4438?journal_id=219012018-01-17T14:10:45ZDavide Pesavento
<ul><li><strong>Status</strong> changed from <i>Code review</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul>