https://redmine.named-data.net/https://redmine.named-data.net/favicon.ico?14759811232018-03-06T00:21:52ZNDN project issue tracking systemndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226252018-03-06T00:21:52ZJunxiao Shi
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default closed" href="/issues/4318">Feature #4318</a>: Content Store flush/erase command</i> added</li></ul> ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226262018-03-06T00:22:19ZJunxiao Shi
<ul><li><strong>Assignee</strong> set to <i>Eric Newberry</i></li><li><strong>Estimated time</strong> set to <i>2.00 h</i></li></ul> ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226272018-03-06T00:22:32ZJunxiao Shi
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Immediate</i></li></ul> ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226292018-03-06T08:58:10ZDavide Pesavento
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/22629/diff?detail_id=19788">diff</a>)</li><li><strong>Estimated time</strong> changed from <i>2.00 h</i> to <i>0.10 h</i></li></ul><p>Renumbering of <em>BaseCongestionMarkingInterval</em> is not going to happen. We have a full implementation based on it and we already shipped that code (and that TLV assignment) in v0.6.1. It is way simpler to just change the assignment for <em>NCsEntries</em>, since it was just merged and is still unimplemented in NFD.</p>
ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226322018-03-06T09:28:36ZJunxiao Shi
<ul><li><strong>Estimated time</strong> changed from <i>0.10 h</i> to <i>1.00 h</i></li></ul><p>The spec has to be updated first. Completing that in 6 minutes is impossible.</p>
ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226332018-03-06T09:31:37ZJunxiao Shi
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-3 status-1 priority-2 priority-default" href="/issues/4539">Task #4539</a>: Management: collect all TLV-TYPE number assignments on the same page</i> added</li></ul> ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226352018-03-06T14:38:13ZEric Newberryenewberry@cs.ucla.edu
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>30</i></li></ul><p>The TLV-TYPE for <code>NCsEntries</code> has been changed to 137 on the ControlCommand, CsMgmt, and ForwarderStatus wiki pages. I also added <code>BaseCongestionMarkingInterval</code> and <code>DefaultCongestionThreshold</code> to the TLV-TYPE list on the ControlCommand page.</p>
ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226362018-03-06T14:43:00ZEric Newberryenewberry@cs.ucla.edu
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Code review</i></li><li><strong>% Done</strong> changed from <i>30</i> to <i>100</i></li></ul><p>Update to ndn-cxx has been pushed to Gerrit.</p>
ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226382018-03-06T14:57:56ZEric Newberryenewberry@cs.ucla.edu
<ul></ul><p>Changes to the <code>NCsEntries</code> TLV-TYPE on the wiki have been reverted and the ndn-cxx change has been abandoned.</p>
ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226392018-03-06T14:59:42ZDavide Pesavento
<ul><li><strong>Status</strong> changed from <i>Code review</i> to <i>Resolved</i></li></ul><p>Eric Newberry wrote:</p>
<blockquote>
<p>The TLV-TYPE for <code>NCsEntries</code> has been changed to 137 on the ControlCommand, CsMgmt, and ForwarderStatus wiki pages.</p>
</blockquote>
<p>You were not supposed to do this. Changing CsInfo and FwStatus datasets is just wrong because it changes the protocol in incompatible ways. ControlCommand updates for NCsEntries will be done by Junxiao in <a class="issue tracker-2 status-5 priority-2 priority-default closed" title="Feature: Content Store flush/erase command (Closed)" href="https://redmine.named-data.net/issues/4318">#4318</a> (I guess).</p>
<blockquote>
<p>I also added <code>BaseCongestionMarkingInterval</code> and <code>DefaultCongestionThreshold</code> to the TLV-TYPE list on the ControlCommand page.</p>
</blockquote>
<p>Ok, I think this issue is resolved then.</p>
ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226402018-03-06T15:11:38ZJunxiao Shi
<ul></ul><blockquote>
<p>Changing CsInfo and FwStatus datasets is just wrong because it changes the protocol in incompatible ways.</p>
</blockquote>
<p>NFD <a class="wiki-page" href="https://redmine.named-data.net/projects/nfd/wiki/Management">Management</a> never guaranteed backwards compatibility.</p>
<blockquote>
<p>ControlCommand updates for NCsEntries will be done by Junxiao in <a class="issue tracker-2 status-5 priority-2 priority-default closed" title="Feature: Content Store flush/erase command (Closed)" href="https://redmine.named-data.net/issues/4318">#4318</a></p>
</blockquote>
<p>I won’t make this change, but neither would I object to such change.</p>
<blockquote>
<p>Renumbering of <em>BaseCongestionMarkingInterval</em> is not going to happen. We have a full implementation based on it and we already shipped that code (and that TLV assignment) in v0.6.1.</p>
</blockquote>
<p>It can happen, given the assignment was not published in protocol spec and thus is internal.</p>
ndn-cxx - Bug #4538: Congestion mark related elements missing in ControlParametershttps://redmine.named-data.net/issues/4538?journal_id=226452018-03-07T14:10:53ZDavide Pesavento
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>