https://redmine.named-data.net/https://redmine.named-data.net/favicon.ico?14759811232018-05-27T18:20:02ZNDN project issue tracking systemndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=233372018-05-27T18:20:02ZJunxiao Shi
<ul><li><strong>Category</strong> set to <i>Base</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>Junxiao Shi</i></li><li><strong>Target version</strong> set to <i>v0.7</i></li><li><strong>Estimated time</strong> set to <i>2.00 h</i></li></ul> ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=233382018-05-27T19:02:22ZJunxiao Shi
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>30</i></li><li><strong>Estimated time</strong> changed from <i>2.00 h</i> to <i>6.00 h</i></li></ul><p><a href="https://gerrit.named-data.net/4767">https://gerrit.named-data.net/4767</a> adds the <code>Interest::setDefaultCanBePrefix</code> function.</p>
<p>I realize that it would be a bad idea to print the warning in <code>Interest</code> contructor, because that means a simple default-construction results in a warning. Thus, the warning is delayed until <code>Interest::wireEncode</code>.</p>
<p>I also realize that ndn-cxx itself cannot call <code>Interest::setDefaultCanBePrefix</code>, because that would conflict the application's choice and mask the application's negligence. Thus, I'll have to review all Interests expressed by ndn-cxx's <code>mgmt security util</code> and set CanBePrefix on a per-Interest basis, so that ndn-cxx itself does not trigger the warning.</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=236202018-07-12T08:31:13ZJunxiao Shi
<ul><li><strong>% Done</strong> changed from <i>30</i> to <i>40</i></li></ul> ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=236322018-07-16T07:26:29ZJunxiao Shi
<ul><li><strong>% Done</strong> changed from <i>40</i> to <i>60</i></li></ul> ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=238342018-08-10T07:54:53ZJunxiao Shi
<ul><li><strong>% Done</strong> changed from <i>60</i> to <i>70</i></li></ul><p><a href="https://gerrit.named-data.net/#/c/ndn-tools/+/4910">https://gerrit.named-data.net/#/c/ndn-tools/+/4910</a> sets CanBePrefix to appropriate values in ndn-tools, except chunks (<a class="issue tracker-3 status-5 priority-3 priority-high3 closed" title="Task: ndncatchunks: stop using Selectors (Closed)" href="https://redmine.named-data.net/issues/4556">#4556</a>) and pib (<a class="issue tracker-2 status-6 priority-2 priority-default closed" title="Feature: Restore PIB service after ndn-cxx security v2 and other breaking changes (Rejected)" href="https://redmine.named-data.net/issues/4205">#4205</a>).</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=240792018-09-22T08:38:38ZDavide Pesavento
<ul><li><strong>Tags</strong> set to <i>Packet03Transition</i></li></ul> ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=245342019-01-13T15:17:35ZJunxiao Shi
<ul><li><strong>% Done</strong> changed from <i>70</i> to <i>80</i></li></ul><p>Most of <strong>PSync</strong> express Interests through <code>SegmentFetcher</code> except one place: <a href="https://gerrit.named-data.net/5115">https://gerrit.named-data.net/5115</a><br>
<strong>ChronoSync</strong> already has <code>setCanBePrefix</code> everywhere.<br>
<strong>NLSR</strong> needs <code>setCanBePrefix</code> in several test suites: <a href="https://gerrit.named-data.net/5116">https://gerrit.named-data.net/5116</a></p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=245842019-01-22T22:10:42ZDavide Pesavento
<ul></ul><p><code>ndn-autoconfig</code> still triggers the warning... and then there are tons of NFD unit tests to fix :-/</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=245852019-01-22T22:19:24ZDavide Pesavento
<ul></ul><p>I'm wondering if "fixing" all the test cases (i.e. adding an explicit <code>setCanBePrefix(true/false)</code>) is a good use of our time. We could simply wait until the default is flipped, and only then fix those tests that fail by adding <code>setCanBePrefix(true)</code>. My assumption is that those tests will be a small fraction of the total.</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=245862019-01-22T23:16:07ZJunxiao Shi
<ul></ul><blockquote>
<p><code>ndn-autoconfig</code> still triggers the warning... and then there are tons of NFD unit tests to fix :-/</p>
</blockquote>
<p>I do not intend to fix NFD and its unit tests. NFD forwarding needs to process packets in v0.3 semantics before its tests can set CanBePrefix to either value. Before then, the warning remains with NFD.</p>
<p>Other programs in NFD repository should be fixed in the same way as PSync, etc.</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=245872019-01-22T23:27:46ZDavide Pesavento
<ul></ul><p>Junxiao Shi wrote:</p>
<blockquote>
<p>I do not intend to fix NFD and its unit tests. NFD forwarding needs to process packets in v0.3 semantics before its tests can set CanBePrefix to either value. Before then, the warning remains with NFD.</p>
</blockquote>
<p>For forwarding tests I agree, but some warnings are triggered by tests that have nothing to do with forwarding, e.g. I've seen warnings in LinkService, Management, etc.</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=251712019-04-04T13:46:08ZDavide Pesavento
<ul></ul><p>Junxiao Shi wrote:</p>
<blockquote>
<p><a href="https://gerrit.named-data.net/4767">https://gerrit.named-data.net/4767</a> adds the <code>Interest::setDefaultCanBePrefix</code> function.</p>
<p>I realize that it would be a bad idea to print the warning in <code>Interest</code> contructor, because that means a simple default-construction results in a warning. Thus, the warning is delayed until <code>Interest::wireEncode</code>.</p>
</blockquote>
<p>The warning is printed twice because the static guard variable is in the scope of a function template which is instantiated twice, so you end up with two separate variables.<br>
The warning message also lacks a trailing newline.</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=252992019-05-07T12:25:53ZJunxiao Shi
<ul><li><strong>% Done</strong> changed from <i>80</i> to <i>90</i></li></ul><p><a href="https://gerrit.named-data.net/5442">https://gerrit.named-data.net/5442</a> clears all CanBePrefix warnings from <code>unit-tests-daemon</code>.<br>
<code>unit-tests-core</code> and <code>unit-tests-rib</code> do not trigger the warning.<br>
<code>unit-tests-tools</code> will be handled in another commit.</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=253782019-05-25T00:55:23ZJunxiao Shi
<ul><li><strong>Start date</strong> deleted (<del><i>04/13/2018</i></del>)</li></ul><p><a href="https://gerrit.named-data.net/5453">https://gerrit.named-data.net/5453</a> clears all CanBePrefix warnings from NFD <code>unit-tests-tools</code>.</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=256302019-07-20T11:51:40ZDavide Pesavento
<ul></ul><p>What's left?</p>
ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=256312019-07-20T11:53:29ZDavide Pesavento
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-3 status-5 priority-2 priority-default closed" href="/issues/4582">Task #4582</a>: Switch default CanBePrefix to false</i> added</li></ul> ndn-cxx - Feature #4581: Default CanBePrefix declarationhttps://redmine.named-data.net/issues/4581?journal_id=256412019-07-22T14:12:06ZJunxiao Shi
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul>