https://redmine.named-data.net/https://redmine.named-data.net/favicon.ico?14759811232019-10-31T15:17:06ZNDN project issue tracking systemNFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=260682019-10-31T15:17:06ZAlex Afanasyev
<ul></ul><p>This is not an issue for the NFD... this is packaging system. If you talking about default config, then we cannot really change it (or need to make system-dependent), as there is no such thing on mac.</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=260692019-10-31T15:19:19ZDavide Pesavento
<ul></ul><p>Yes, I'm talking about the configuration file and whatever other default we have in the code. And yes, this is for Linux only.</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=263512020-02-13T21:21:10ZEric Newberryenewberry@cs.ucla.edu
<ul></ul><p>So is the issue with changing this that /run not exist on macOS?</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265152020-04-02T12:13:58ZEric Newberryenewberry@cs.ucla.edu
<ul><li><strong>Assignee</strong> set to <i>Eric Newberry</i></li></ul> NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265212020-04-02T19:23:48ZEric Newberryenewberry@cs.ucla.edu
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265222020-04-02T19:27:06ZEric Newberryenewberry@cs.ucla.edu
<ul></ul><p>How do we handle config files that refer to /var/run/nfd.sock?</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265262020-04-02T19:35:55ZDavide Pesavento
<ul></ul><p>What do you mean by "handle"? Whatever value appears in the config file takes precedence over the (hardcoded) default.</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265302020-04-04T14:44:02ZEric Newberryenewberry@cs.ucla.edu
<ul><li><strong>Target version</strong> set to <i>22.02</i></li></ul><p>Davide Pesavento wrote:</p>
<blockquote>
<p>What do you mean by "handle"? Whatever value appears in the config file takes precedence over the (hardcoded) default.</p>
</blockquote>
<p>Sorry, I mean the default. By default, the config file refers to <code>/var/run/nfd.sock</code>. I see four possible solutions (please let me know what you think of each):</p>
<ul>
<li>(a) Have different default config files for each platform (seems difficult and error-prone, especially with keeping the two versions consistent).</li>
<li>(b) Perform some processing at compile-time to put different defaults for each platform in the config file (seems like overkill).</li>
<li>(c) Leave <code>/var/run/nfd.sock</code> in the config file, since this still works on Linux due to the symbolic link, and have the hardcoded default in the code be platform-specific (easiest).</li>
<li>(d) Leave <code>/var/run/nfd.sock</code> in the config file, but comment it out so that the hardcoded platform-specific path in code is used by default (my preferred solution, seems easy and not hacky - can also add a comment indicating default values for each platform in the config file).</li>
</ul>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265312020-04-04T14:57:57ZDavide Pesavento
<ul></ul><p>We already do (b) so it's not overkill, and in fact it would be trivial to add the socket path to that existing logic. (d) is fine as well. (a) is unmaintainable and strictly worse than (b). (c) is pointless.<br>
In summary, I'd be ok with either (b) or (d).</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265342020-04-07T00:05:32ZEric Newberryenewberry@cs.ucla.edu
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Code review</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>I went with option (b), as discussed above.</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265352020-04-08T09:58:44ZEric Newberryenewberry@cs.ucla.edu
<ul><li><strong>Status</strong> changed from <i>Code review</i> to <i>Closed</i></li></ul> NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265362020-04-08T10:48:22ZDavide Pesavento
<ul></ul><p>Can you please open a ticket with <a href="https://redmine.named-data.net/projects/ndn-ccl/issues" class="external">CCL</a> and <a href="https://github.com/zjkmxy/python-ndn/issues" class="external">python-ndn</a> to inform them of the change?</p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265372020-04-08T11:45:41ZEric Newberryenewberry@cs.ucla.edu
<ul></ul><p>Davide Pesavento wrote:</p>
<blockquote>
<p>Can you please open a ticket with <a href="https://redmine.named-data.net/projects/ndn-ccl/issues" class="external">CCL</a> and <a href="https://github.com/zjkmxy/python-ndn/issues" class="external">python-ndn</a> to inform them of the change?</p>
</blockquote>
<p>Done.</p>
<p><a href="https://redmine.named-data.net/issues/5099">https://redmine.named-data.net/issues/5099</a></p>
<p><a href="https://github.com/zjkmxy/python-ndn/issues/6">https://github.com/zjkmxy/python-ndn/issues/6</a></p>
NFD - Task #5039: Move socket file to /run on Linuxhttps://redmine.named-data.net/issues/5039?journal_id=265392020-04-09T01:16:20ZXinyu Ma
<ul></ul><p>Fixed by <a href="https://github.com/zjkmxy/python-ndn/commit/11a47048ea2fcad6983837a29d0cfabf24b8ce69">https://github.com/zjkmxy/python-ndn/commit/11a47048ea2fcad6983837a29d0cfabf24b8ce69</a></p>