Task #1838
closed
Expect markers in StatusDataset and NotificationStream consumers
Added by Junxiao Shi over 9 years ago.
Updated over 9 years ago.
Description
In StatusDataset consumers, expect 0xFD marker on version component, expect 0x00 marker on segment component.
In NotificationStream consumers, expect 0xFE marker on sequence number component.
- Related to Task #1837: Include markers in StatusDataset and NotificationStream publishers added
- Status changed from New to In Progress
I determine it's more efficient to complete this Task at the same time as #1837, so these will be in one commit.
- % Done changed from 0 to 60
I notice that FaceMonitor
lacks unit testing. I'm adding them as part of this Task.
- Status changed from In Progress to Code review
- % Done changed from 60 to 100
Making FaceMonitor
testable is a lot of work. In this process, I also refactor this class to a generic NotificationSubscriber
template.
- Status changed from Code review to Closed
Also available in: Atom
PDF