NFD

This also affects ./rib/fib-updater.cpp in NFD's master branch.

While waiting for uClibc to be updated, would there be any issues stopping us from switching to the boost function? NFD is already pulling in those libraries so there wouldn't be any extra dependencies and doing so would help ensure that the NFD code compiles nicely in many different environments.

In many places, I personally tried to reduce use of boost::lexical_cast, as it is suppose to be slower than to_string. I would suggest that we better add an emulation of to_string specifically for uClibc platform (and may be some others).

I would suggest that we better add an emulation of to_string specifically for uClibc platform (and may be some others).

It's unnecessary to use platform-specific emulation.

Instead, detect this feature in .waf-tools/compiler-features.py, and fallback to boost::lexical_cast<std::string> if std::to_string isn't detected.

I disagree with this. Having dependent code (I'm assuming you're suggesting ifdefs all over the place) makes implementation cumbersome...

So. Either we do emulation, figure out flags to allow gcc on these platforms to expose to_string, or fall back to lexical_cast (this would be my last resort).

@Mathias. We have to_string in a few other places. All of them cause the error or the compilation simply stopped at the first error?

I'm assuming you're suggesting ifdefs all over the place

You misunderstood note-4.

#ifdef appears only in common.hpp, which enables:

namespace std {

template<typename V>
std::string
to_string(const V& v)
{
  return boost::lexical_cast<std::string>(v);
}

} // namespace std

The point is, emulation is enabled as a result of feature detection, not as a result of library version detection.

@Alex, I did a grep to find where ever std::to_string was used in the NFD code. In the current master there are only two occurrences. The build stops at the first one, but either of them will cause the error.

@Junxiao, I like your proposed solution.

I can confirm that the patch works and resolves compilation error I was getting before. Thanks!