Project

General

Profile

Actions

Bug #3279

closed

Schedule doesn't encode RepetitiveInterval in ascending order

Added by Anonymous over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
10/20/2015
Due date:
% Done:

100%

Estimated time:

Description

In Schedule::wireEncode, the fields are encoded in reverse order (as normal), so the RepetitiveInterval iterator should go backwards to put the encoded elements in ascending order. But the iterator goes forward: https://github.com/named-data/ndn-group-encrypt/blob/7cc09fc4e97adcab02731b99efb96eecdf81364b/src/schedule.cpp#L50

Is it your intention that the RepetitiveInterval elements should be encoded in ascending order? Or does the encoding specify and order? (If there is not a defined order, then it's hard to make the unit tests pass because the results will vary from test cases.)


Related issues 1 (0 open1 closed)

Blocked by NAC - Bug #3533: RepetitiveInterval "less" operator is not implemented correctly.ClosedYingdi Yu03/09/2016

Actions
Actions #1

Updated by Yingdi Yu about 8 years ago

  • Blocked by Bug #3533: RepetitiveInterval "less" operator is not implemented correctly. added
Actions #2

Updated by Yingdi Yu about 8 years ago

  • Status changed from New to Code review
  • Assignee set to Yingdi Yu
  • % Done changed from 0 to 80
Actions #3

Updated by Yingdi Yu about 8 years ago

  • Status changed from Code review to Closed
  • % Done changed from 80 to 100
Actions

Also available in: Atom PDF