Task #4105
closedMerge Fib::update and Fib::processUpdate
0%
Description
Currently, the Fib splits the responsibility of updating an entry's next-hop list into two parts: one public access and one private access. However, even though Fib::update is public and Fib::processUpdate is private, Fib::processUpdate is called without any modification of the arguments to Fib::update. That is, you could directly replace the call to Fib::update with Fib::processUpdate and additionally the scheduling code snippet and they would be equivalent. So then there is no utility gained by splitting the operation into two parts and only exposing one part of it.
Since there is no obvious situation in which the parameters would need to change from one part to the next, they should be merged into one function, say Fib::update, that is publicly exposed. This would simplify the specification for the Fib class, and make it easier to understand and document.
Updated by Nicholas Gordon about 7 years ago
- Status changed from In Progress to Code review
Updated by Nicholas Gordon about 7 years ago
- Status changed from Code review to Closed