Project

General

Profile

Actions

Bug #4254

closed

Task #4253: Unit tests should be more deterministic

Fix SyncLogicHandler's tests

Added by Nicholas Gordon over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
08/21/2017
Due date:
% Done:

0%

Estimated time:

Description

The tests TestSyncLogicHandler/UpdateForOtherHR and TestSyncLogicHandler/UpdateForOtherLS in the file tests/test-sync-logic-handler.cpp are not deterministic, and sometimes will fail because other interests have been sent, while the tests are expecting only one. Due to the asynchronous, network-level nature of NLSR, we cannot guarantee ordering, so the tests must be changed to be independent of ordering.

Actions #1

Updated by Nicholas Gordon over 7 years ago

  • Subject changed from Fix SyncLogicHandler's UpdateForOther test to Fix SyncLogicHandler's UpdateForOtherHR test
  • Description updated (diff)
Actions #2

Updated by Nicholas Gordon over 7 years ago

  • Subject changed from Fix SyncLogicHandler's UpdateForOtherHR test to Fix SyncLogicHandler's tests
  • Description updated (diff)
Actions #3

Updated by Nicholas Gordon about 7 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF