Actions
Task #4877
closed
The ShouldAddToSyncDataCallback in FullProducer should check for sequence zero
Status:
Abandoned
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
03/12/2019
Due date:
% Done:
0%
Estimated time:
Description
In the old code, onSyncInterest checked for sequence number zero
https://github.com/named-data/PSync/blob/e5fdcc3744d3787949aec0ef23ba9fc8a7db4572/PSync/full-producer.cpp#L198
if (m_prefixes[prefix] != 0 && !isFutureHash(prefix.toUri(), negative)) {
But in the new code, the ShouldAddToSyncDataCallback just checks the future hash.
https://github.com/8th-ndn-hackathon/PSync/blob/0fb388245a429e651ea15ac1f62696d4e5cfdbcb/PSync/full-producer.cpp#L46
Does it also need to check for sequence number zero? (Maybe this check was dropped accidentally during refactoring.)
Updated by Anonymous about 5 years ago
- Status changed from New to Abandoned
Nevermind. It gets the Name from m_hash2name which never has a name with sequence number zero. (So maybe the check was not necessary in the original code.) Abandoning this issue.
Actions