Project

General

Profile

Actions
Copy link

Task #1481

closed

Change constructor of Validator classes

Added by Yingdi Yu over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Yingdi Yu
Category:
Security
Target version:
v0.1
Start date:
04/14/2014
Due date:
% Done:

100%

Estimated time:

Description

In current implementation, the Face member of Validator is defined as shared_ptr<Face>.
The constructor of Validator also requires shared_ptr<Face>.
This forces applications that use validators to allocate Face in heap.

In this task, we need to change shared_ptr<Face> to Face&.

Actions
Copy link
 #1

Updated by Yingdi Yu over 10 years ago

  • Assignee set to Yingdi Yu
Actions
Copy link
 #2

Updated by Yingdi Yu over 10 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Alex Afanasyev over 10 years ago

  • Status changed from Code review to In Progress
  • % Done changed from 100 to 80

We can remove the old API now (in a new commit).

Actions
Copy link
 #4

Updated by Yingdi Yu over 10 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 80 to 100
Actions
Copy link
 #5

Updated by Yingdi Yu over 10 years ago

  • Category set to Security
  • Status changed from Code review to Closed
  • Target version set to v0.1
Actions
Copy link

Also available in: Atom PDF