Project

General

Profile

Task #1707

Reduce implicit digest computation in Interest::matchesData

Added by Junxiao Shi over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Base
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

Interest::matchesData always requests the full Name (including the implicit digest component) of the Data packet, which requires implicit digest computation.
This is unnecessary unless the Interest Name probably contains the implicit digest as its last component or the Interest probably excludes the implicit digest of the Data.
Most Interests do not appear to contain or exclude the implicit digest, so that we can optimize for the expected case.

This Task is to avoid requesting the full Name of the Data packet unless it's necessary.


Related issues

Related to NFD - Task #1706: Reduce implicit digest computation in ContentStoreClosedJunxiao Shi

Actions
#1

Updated by Junxiao Shi over 6 years ago

  • Related to Task #1706: Reduce implicit digest computation in ContentStore added
#2

Updated by Junxiao Shi over 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • Target version set to v0.3
#3

Updated by Junxiao Shi over 6 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
#4

Updated by Junxiao Shi over 6 years ago

This Task does not conflict with ImplicitSha256DigestComponent #1640.

Currently, my code assumes an Interest Name might end with a digest if the last component is 32 octets.
With #1640, the code shall be updated to detect a digest by ImplicitSha256DigestComponent type, and treat everything else non-digest.

#5

Updated by Junxiao Shi over 6 years ago

  • Status changed from Code review to Closed
#6

Updated by Junxiao Shi over 3 years ago

  • Status changed from Closed to Resolved

https://gerrit.named-data.net/3991 fixes a typo in Interest::matchesData function, and deletes an inaccurate statement in Doxygen.

#7

Updated by Junxiao Shi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF