Actions
Bug #2236
closedInaccurate comment in Interest::matchesData
Start date:
11/27/2014
Due date:
% Done:
100%
Estimated time:
0.50 h
Description
The following comment in Interest::matchesData
becomes inaccurate after ImplicitSha256DigestComponent
is introduce:
// There's opportunity to inspect the Exclude filter and determine whether
// the digest would make a difference.
// eg. "Exclude=<Any>AA" won't exclude any digest - fullName not needed
// "Exclude=ZZ<Any>" excludes all digests - fullName not needed
// "Exclude=<Any>80000000000000000000000000000000"
// excludes half of the digests - fullName required
// But Interests that contain the exact Data Name before digest and also
// contain Exclude filter is too rare to optimize for, so we request
// fullName no mater what's in the Exclude filter.
While the "opportunity" still exists, the example shown is incorrect.
Updated by Junxiao Shi almost 10 years ago
- Status changed from New to In Progress
Updated by Junxiao Shi almost 10 years ago
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
Updated by Junxiao Shi almost 10 years ago
- Status changed from Code review to Closed
Actions