Task #2257: ndns-add-rr-from-file segfaults when input file cannot be loaded - ndns - NDN project issue tracking system

Actions

Copy link

Task #2257

closed

ndns-add-rr-from-file segfaults when input file cannot be loaded

Added by Alex Afanasyev over 9 years ago. Updated about 9 years ago.

Status:

Closed

Priority:

High

Assignee:

Jiewen Tan

Target version:

0.1

Start date:

12/01/2014

Due date:

% Done:

Estimated time:

Description

Here is what I'm running, where cert-file some random stuff

ndns@spurs:~/repo2ndns$ ./ndns/build/bin/ndns-add-rr-from-file /ndn cert-file

Expected output:

Error: input does not contain a valid Data packet (is it in base64 format?)

Actual:

Segmentation fault

partial gdb backtrace:

(gdb) bt
#0  0x08178f73 in ndn::RegexTopMatcher::match(ndn::Name const&) ()
#1  0x080d4d32 in ndn::ndns::ManagementTool::addRrSet (this=0xbffffbe0, zoneName=..., inFile=..., ttl=...,
    inputDskCertName=...) at ../src/mgmt/management-tool.cpp:339
#2  0x0809dd1b in main (argc=3, argv=0xbffffd04) at ../tools/ndns-add-rr-from-file.cpp:113

Before line 339 in management-tool.cpp, nobody is checking that data points to a valid data packet.