Project

General

Profile

Actions

Task #2289

closed

SyncLogicHandler should be responsible for constructing the router's LSA update prefix

Added by Vince Lehman over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Low
Assignee:
Target version:
-
Start date:
12/11/2014
Due date:
% Done:

100%

Estimated time:

Description

Currently, when the LSDB publishes a routing update, the LSDB constructs the LSA update prefix. The same code appears in 4 different places in lsdb.cpp.

ndn::Name lsaPrefix = m_nlsr.getConfParameter().getLsaPrefix();
lsaPrefix.append(m_nlsr.getConfParameter().getSiteName());
lsaPrefix.append(m_nlsr.getConfParameter().getRouterName());
m_nlsr.getSyncLogicHandler().publishRoutingUpdate(m_nlsr.getSequencingManager(), lsaPrefix);

Also, the LSDB passes a SequencingManager obtained from the Nlsr instance each time it calls publishRoutingUpdate.

Instead, SyncLogicHandler should construct and maintain the LSA update prefix and have a reference to the Nlsr's SequenceManager.

SyncLogicHandler::publishRoutingUpdate can be refactored to take no parameters and the LSDB can simply call:

m_nlsr.getSyncLogicHandler().publishRoutingUpdate();
Actions #1

Updated by Vince Lehman over 9 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 90
Actions #2

Updated by Vince Lehman over 9 years ago

  • Assignee set to Vince Lehman
Actions #3

Updated by Vince Lehman over 9 years ago

  • Status changed from Code review to Closed
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF