Project

General

Profile

Actions

Bug #3884

closed

lp::detail::FieldInfo::canIgnore wrong logic

Added by Junxiao Shi about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Base
Target version:
Start date:
12/11/2016
Due date:
% Done:

100%

Estimated time:

Description

NDNLPv2 revision 8 defines:

If an incoming LpPacket contains an unknown LpHeaderField, the following rules apply:
if the unknown field is in range [800:959], and the two least significant bits are 00, the receive SHOULD ignore the field, and continue processing the packet;
otherwise, the receiver MUST drop the packet, but SHOULD NOT consider the link has an error.

However, ndn::lp::detail::FieldInfo::canIgnore is set to true if the two least significant bits are 01.
Also, the error message in this situation is unhelpful: it should indicate the TLV-TYPE code of the bad element.

Actions #1

Updated by Junxiao Shi about 8 years ago

  • Assignee set to Eric Newberry

This is assigned to Eric who controls NDNLPv2 specification.

Actions #2

Updated by Eric Newberry about 8 years ago

  • Status changed from New to In Progress

I assume this is a coding issue and not a protocol design issue?

Actions #3

Updated by Eric Newberry about 8 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions #4

Updated by Eric Newberry about 8 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF