Project

General

Profile

Actions
Copy link

Bug #3955

closed

FaceStatus: plural of "data" is "data"

Added by Junxiao Shi over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Junxiao Shi
Category:
Management
Target version:
v0.6
Start date:
02/08/2017
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

FaceMgmt FaceStatus struct contains nInDatas and nOutDatas fields. However, the plural form of "data" is "data", not "datas". Thus, these fields should be renamed as nInData and nOutData.
This should be changed in:

  • FaceMgmt spec
  • ndn::nfd::FaceStatus type and its usage in NFD
  • nfdc status report xml schema and corresponding implementation
Actions
Copy link
 #1

Updated by Junxiao Shi over 8 years ago

Given 0.7.0 is a breaking change, it is a good time to fix this historical mistake.
Note that this would not cause a wire format change: an old library that labels the TLV-TYPE as nInDatas/nOutDatas would continue to encode and decode the struct correctly.

Actions
Copy link
 #2

Updated by Junxiao Shi over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • % Done changed from 0 to 10

FaceMgmt page is corrected in r67. ForwarderStatus page is corrected in r8.

Actions
Copy link
 #3

Updated by Junxiao Shi over 8 years ago

  • % Done changed from 10 to 40
Actions
Copy link
 #4

Updated by Junxiao Shi over 8 years ago

  • % Done changed from 40 to 80
Actions
Copy link
 #5

Updated by Junxiao Shi over 8 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 80 to 100

Eventual removal will be performed in #3988.

Actions
Copy link

Also available in: Atom PDF