Feature #4004
closednfdc face create: reliability option
100%
Description
In nfdc face create command, add a command line option to enable/disable best-effort link reliability.
Updated by Junxiao Shi almost 8 years ago
- Blocked by Feature #4003: FaceMgmt: enable link reliability added
Updated by Junxiao Shi almost 8 years ago
There currently isn't an nfdc face update command. Please suggest if it makes sense to introduce one. If so, a separate issue should be created for that.
Updated by Eric Newberry almost 8 years ago
Junxiao Shi wrote:
There currently isn't an nfdc face update command. Please suggest if it makes sense to introduce one. If so, a separate issue should be created for that.
I think that this command makes sense for consistency with FaceMgmt.
Updated by Junxiao Shi over 7 years ago
consistency with FaceMgmt
This is not a valid reason. Command line tools should come from a user story of the operator. They don't have to expose everything allowed by the protocol.
So the questions are:
- Is there is a use case when an operator needs to reduce face persistency level?
- Increasing face persistency level is supported in nfdc face create.
- This is about the human operator. If a routing daemon or other program needs this feature, they would use the protocol client programmatically.
- Is there a use case when an operator needs to enable or disable reliability, AFTER a face has created?
- If so, should nfdc face create allow changing reliability settings, or should it appear in a separate command?
- Is there a use case for setting link reliability options (timers, max retx, etc) on a per-face basis?
- If so, should they be added to the protocol and appear as nfdc face create options, or added as a separate command, or added as predicate-based rules in
face_system
config section?
- If so, should they be added to the protocol and appear as nfdc face create options, or added as a separate command, or added as predicate-based rules in
Updated by Eric Newberry over 7 years ago
Regardless of whether there is a valid reason, what I'm saying is IF we decide to add this feature, it should be organized under an "nfdc face update" command. It doesn't make sense to update an existing face with the "create" command since we're not creating anything. It also keeps consistency with the actual FaceMgmt interface (faces/update).
Updated by Eric Newberry over 7 years ago
Although there should also be an option to enable/disable reliability when the face is created.
Updated by Eric Newberry over 7 years ago
- Related to Feature #3823: Congestion Control: design Local Link Loss Detection added
Updated by Eric Newberry over 7 years ago
- Status changed from New to In Progress
Updated by Eric Newberry over 7 years ago
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
Updated by Eric Newberry over 7 years ago
- Status changed from Code review to Closed