Actions
Bug #4072
closed
Tpm::exportPrivateKey doc comment is wrong
Start date:
Due date:
% Done:
100%
Estimated time:
Description
The doc comment for Tpm::exportPrivateKey says "@return The encoded private key wrapper or an empty block if the key cannot be exported."
https://github.com/named-data/ndn-cxx/blob/fe4733a1608712e389fe10b329a9fd61575ad075/src/security/tpm/tpm.hpp#L188
But this method just calls BackEnd::exportKey which says "@throw Error the key does not exist".
https://github.com/named-data/ndn-cxx/blob/fe4733a1608712e389fe10b329a9fd61575ad075/src/security/tpm/back-end.hpp#L98
I believe that this is correct and that Tpm::exportPrivateKey should be changed to say "@throw BackEnd::Error the key does not exist".
Updated by Davide Pesavento over 7 years ago
- Category set to Security
- Status changed from New to Code review
- Assignee set to Davide Pesavento
- Target version set to v0.6
- Start date deleted (
05/03/2017) - % Done changed from 0 to 100
Updated by Davide Pesavento over 7 years ago
- Status changed from Code review to Closed
Actions