Actions
Bug #4081
closed
MulticastEthernetTransport: promiscuous mode fallback is broken
Start date:
Due date:
% Done:
100%
Estimated time:
Description
pcap_set_promisc must be called before pcap_activate, otherwise it has no effect.
MulticastEthernetTransport has always done the inverse, which means that the fallback has never been functional.
Updated by Davide Pesavento over 7 years ago
Given that:
- The two other methods to join the multicast group are strictly better and they cover all of our supported platforms
- Nobody so far complained about promisc mode not working
- Changing the order of the calls is non-trivial, because we need the fd to try the other methods, and to get the fd we need to call
pcap_activatefirst => chicken and egg situation
I think it's safe to assume that no one has ever used or relied on the fallback. Therefore, I propose that we simply remove it.
Updated by Davide Pesavento over 7 years ago
- Status changed from New to Code review
- % Done changed from 0 to 100
Updated by Davide Pesavento over 7 years ago
- Status changed from Code review to Closed
Actions