Project

General

Profile

Task #4108

Replace MapEntry with a POD

Added by Nicholas Gordon about 3 years ago. Updated about 2 years ago.

Status:
Abandoned
Priority:
Normal
Assignee:
-
Target version:
Start date:
05/31/2017
Due date:
% Done:

0%

Estimated time:

Description

Currently the Map class used in the RoutingTable maintains a collection of MapEntry objects. However, these objects are only used within Map, and MapEntry only serves to aggregate two values. This collection is essentially a POD, and separating it into its own class suggests that it should have some behavior of its own. Since it doesn't, this could be considered confusing. It also slows down compile times and damages readability, by adding complexity in an entirely unnecessary way.

Instead, this could be represented with a const tuple or a const struct, since the class as-implemented wants to be immutable. Re-implementing it as a POD would save almost 100 LOC, prevent an include, and ease readability.

#1

Updated by Nicholas Gordon over 2 years ago

  • Status changed from In Progress to New
  • Assignee deleted (Nicholas Gordon)
  • Target version changed from v0.4.0 to v0.5.0
#2

Updated by Nicholas Gordon over 2 years ago

  • Target version changed from v0.5.0 to Minor release 0.4.1
#3

Updated by Ashlesh Gawande over 2 years ago

  • Target version changed from Minor release 0.4.1 to v0.5.0
#4

Updated by Nicholas Gordon about 2 years ago

  • Status changed from New to Abandoned

Also available in: Atom PDF