Project

General

Profile

Actions

Feature #4164

closed

Make Interest/Data constructor explicit

Added by Junxiao Shi over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Base
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

Mark explicit on Interest and Data constructor, because there's no reason to allow implicit conversion from Name.

Actions #1

Updated by Junxiao Shi over 7 years ago

Only a small number of ndn-cxx test cases are relying on implicit conversion from Name. No dependent projects are affected https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/250577853

Actions #2

Updated by Junxiao Shi over 7 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 100
Actions #3

Updated by Junxiao Shi over 7 years ago

  • Status changed from Code review to Closed
Actions #4

Updated by Junxiao Shi over 7 years ago

  • Subject changed from Make Interest constructor explicit to Make Interest/Data constructor explicit
  • Description updated (diff)
  • Status changed from Closed to Resolved
  • Start date deleted (07/05/2017)

https://gerrit.named-data.net/4055 does the same for Data.
No dependant project (that isn't already broken) is affected https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/256754125.

Actions #5

Updated by Junxiao Shi over 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF