Project

General

Profile

Actions

Feature #4267

open

Remove explicit TLV classes

Added by Nicholas Gordon over 6 years ago. Updated over 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)

Description

Currently, NLSR maintains a separate set of classes and data structures for the purposes of data serialization. This is overly complicated and not viable in the long-term.

  • NLSR will not duplicate existing data structures for the purposes of serialization.

Subtasks 3 (3 open0 closed)

Task #4269: Design common TLV system.New

Actions
Task #4270: Write tests for the common TLV system.New

Actions
Task #4271: Implement common TLV system.New

Actions

Related issues 1 (0 open1 closed)

Has duplicate NLSR - Task #4787: Consolidate src/tlv/**lsa** into src/**lsa**ClosedAshlesh Gawande

Actions
Actions #1

Updated by Nicholas Gordon over 6 years ago

  • Tracker changed from Task to Feature
  • Description updated (diff)
  • Start date deleted (09/05/2017)

Currently NLSR maintains a set of separate classes for encoding data structures to TLV format. In my view, this is not an optimal approach. This is a simple problem to solve, since the process is similar each time, and is a basic transformation to a string. This can be accomplished by a free function, for example, or by a method that employs a common helper function. Further, continually duplicating TLV classes is not a tenable long-term design paradigm -- as the number of published things increases, complexity of these structures will increase, leading to double the maintenance work. We should aim to minimize the code surface, and only add complexity when necessary.

Actions #2

Updated by Ashlesh Gawande about 4 years ago

  • Has duplicate Task #4787: Consolidate src/tlv/**lsa** into src/**lsa** added
Actions

Also available in: Atom PDF