NFD » ndn-tools

This is just a simple task for Chavoosh to get started with the coding procedure.

Davide Pesavento wrote:

The function PipelineInterestsAimd::printSummary() should be moved to PipelineInterests::printSummary()

It's not so simple. Several quantities printed by PipelineInterestsAimd::printSummary are not available in the base class. Moreover, the fixed-window pipeline simply does not track things such as the # of loss events and the # of retransmitted Interests, so it cannot print them.

Totally agree that it's not quite as simple.

For getting Chavoosh started, I think it's fine to just have some basic output for all pipelines (like completion time and throughput). And then the specific pipeline (like AIMD) can overwrite the printSummary() to include parts that are not available in other pipelines.

Shuo started doing this, not sure in what state the code was but you may take a look: https://gerrit.named-data.net/3746

Good point.

Klaus Schneider wrote:

Davide Pesavento wrote:

The function PipelineInterestsAimd::printSummary() should be moved to PipelineInterests::printSummary()

It's not so simple. Several quantities printed by PipelineInterestsAimd::printSummary are not available in the base class. Moreover, the fixed-window pipeline simply does not track things such as the # of loss events and the # of retransmitted Interests, so it cannot print them.

Totally agree that it's not quite as simple.

For getting Chavoosh started, I think it's fine to just have some basic output for all pipelines (like completion time and throughput). And then the specific pipeline (like AIMD) can overwrite the printSummary() to include parts that are not available in other pipelines.

Shuo started doing this, not sure in what state the code was but you may take a look: https://gerrit.named-data.net/3746

Good point.

Davide Pesavento wrote:

The function PipelineInterestsAimd::printSummary() should be moved to PipelineInterests::printSummary()

It's not so simple. Several quantities printed by PipelineInterestsAimd::printSummary are not available in the base class. Moreover, the fixed-window pipeline simply does not track things such as the # of loss events and the # of retransmitted Interests, so it cannot print them.

Shuo started doing this, not sure in what state the code was but you may take a look: https://gerrit.named-data.net/3746

Tracking statistical info of packet delivery is still is pipelines' responsibility. E.g. if AIMD wants to use printSummary() method it should gather statics of packet delivery and pass them to printSummary() method. Simply put, this method is nothing more than a printer, where receives its info through arguments.

I have moved printSummary method to pipeline-interests.cpp file. However, I cannot push my changes. I will fix the problem and push them.

Were you able to push to gerrit?

You can post your error message here, so we can help.

In code review: https://gerrit.named-data.net/c/4220/