Project

General

Profile

Actions

Bug #4548

closed

Potential null pointer dereference in FaceManager

Added by Davide Pesavento over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Management
Target version:
Start date:
03/15/2018
Due date:
% Done:

100%

Estimated time:

Description

The handler connected to the Face::afterStateChange signal blindly dereferences the pointer returned by FaceTable::get(), which may be null if the face has already been removed from the table. This can happen when newState == CLOSED.

In practice, this doesn't cause a segfault because the dereferenced null pointer is not actually used in that case. Nevertheless, it's still undefined behavior.

Actions #1

Updated by Davide Pesavento over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Davide Pesavento over 6 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions #3

Updated by Davide Pesavento over 6 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF