IBLT::listEntries should initially clear the result sets
IBLT::listEntries takes a reference to the positive and negative sets and inserts values:
Normally, listEntries is called with new empty sets. But if the sets are re-used in a future call to listEntries, there could be unexpected side effects.
For example, the following unit test re-uses these sets. Luckily this test still works, even though there could have been unexpected side effects of re-using the sets:
I suggest that listEntries should first clear the entries, and explain this in the method documentation.
This is a low-priority comment because IBLT is only used in the PSync code which always calls listEntries with new empty sets. But it is a small change and could avoid future confusion.
No data to display