Feature #4913
closed
Update Interest::matchesData for v0.3 semantics
100%
Description
Stop processing Selectors in Interest::matchesData.
Deprecate ill-designed and unused Interest::matchesName function.
Updated by Junxiao Shi over 5 years ago
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
Updated by Junxiao Shi over 5 years ago
- % Done changed from 0 to 10
https://gerrit.named-data.net/5445 patchset1 is the basic change.
I anticipate broken test cases in ndn-cxx and other projects.
Updated by Junxiao Shi over 5 years ago
- % Done changed from 10 to 70
https://gerrit.named-data.net/5445 patchset2 fixes ndn-cxx tests.
I have confirmed NFD, ChronoSync, PSync, and repo-ng tests are unaffected.
https://gerrit.named-data.net/5450 fixes ndn-tools tests.
https://gerrit.named-data.net/5451 fixes NLSR tests.
Updated by Junxiao Shi over 5 years ago
In https://gerrit.named-data.net/5445 patchset2, Interest to Interest comparison only considers Name, CanBePrefix, and MustBeFresh.
Regarding other fields:
- ForwardingHint: should be considered, but there are implications in NFD's PIT structure, so I'm not changing it until #3162.
- Nonce, InterestLifetime, HopLimit: should not be considered because they do not affect Interest-Data matching and do not create separate PIT entries.
- ApplicationParameters: should be considered, and it's already covered by comparing Name via the ParametersSha256DigestComponent being implemented in #4658.
Updated by Junxiao Shi over 5 years ago
- Status changed from In Progress to Code review
- % Done changed from 70 to 100
I have confirmed NFD tests are unaffected.
Oh well, I forgot unit-tests-tools. It's fixed in https://gerrit.named-data.net/5452
Updated by Junxiao Shi over 5 years ago
- Status changed from Code review to Closed