Bug #5200
closed
Check for dummy keychain failing due to Popen output type changes
100%
Description
Our previous assumptions for interactions with the subprocess module had been communicate() returning a string, leading to "this line":https://github.com/named-data/mini-ndn/blob/master/minindn/minindn.py#L108 working as intended. Due to what I believe to have been an evidently unnoticed change with the Python3 migration, this code will now always fail due to communicate() returning a byte type instead. This type difference will cause this code to always return false. This causes significant startup delays for NFD and NLSR as several bottlenecking tasks are linked to this flag being unset if our recommendation to use this patch is followed.
This appears to be reproducible with all Mini-NDN code.
Updated by Alexander Lane almost 3 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Our previous assumptions for interactions with the subprocess module had been communicate() returning a string, leading to "this line":https://github.com/named-data/mini-ndn/blob/master/minindn/minindn.py#L108 working as intended. Due to what I believe to have been an evidently unnoticed change with the Python3 migration, this code will now always fail due to communicate() returning a byte type instead. This type difference will cause this code to always return false. This causes significant startup delays for NFD and NLSR as several bottlenecking tasks are linked to this flag being unset if our recommendation to use this patch is followed.
This appears to be reproducible with all Mini-NDN code.
Updated by Alexander Lane almost 3 years ago
- Status changed from Resolved to Closed