Project

General

Profile

Actions

Task #5308

open

Code cleanup in LSA and routing table related types

Added by Junxiao Shi 10 months ago. Updated 9 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Target version:
-
Start date:
01/10/2024
Due date:
% Done:

60%

Estimated time:
Actions #1

Updated by Junxiao Shi 10 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30
Actions #2

Updated by Junxiao Shi 10 months ago

  • % Done changed from 30 to 40

https://gerrit.named-data.net/c/NLSR/+/7322 Map

I plan to rename this type to NameMap in upcoming changes, to better reflect what it does.

Actions #3

Updated by Junxiao Shi 9 months ago

  • % Done changed from 40 to 50
Actions #4

Updated by Junxiao Shi 9 months ago

  • % Done changed from 50 to 60

https://gerrit.named-data.net/c/NLSR/+/7393 reduces the API surface of link-state calculator and hyperbolic calculator to a free function each.
This ensures external callers, including unit tests, do not rely on the class structures.

https://gerrit.named-data.net/c/NLSR/+/7396 fixes a bug in link-state calculator.
The test suite is adjusted so that each test can build the topology with desired LSAs, instead of modifying the LSDB after it's populated.

In upcoming changes for the calculators, I plan to adopt resource acquisition is initialization pattern (instead of new + delete) and use Boost-provided data structures where feasible.
I also plan to eliminate the big classes in favor of simpler functions or smaller classes.
The test suite would not be touched in those changes.

Actions

Also available in: Atom PDF