Project

General

Profile

Task #4837

Updated by Jeff Thompson 6 months ago

In ProducerBase, the m_segmentPublisher is initialized with a default KeyChain. The constructor does not allow the caller to specify the KeyChain or the SigningInfo.<br>
https://github.com/named-data/PSync/blob/0cf4b600e91455ee07c38eb22876aa6b653bc14b/PSync/producer-base.cpp#L48

Also, SegmentPublisher::publish has an optional signingInfo parameter, but this is never used.<br>
https://github.com/named-data/PSync/blob/e5fdcc3744d3787949aec0ef23ba9fc8a7db4572/PSync/segment-publisher.hpp#L58

Did you intend to hardwire PSync to only be able to use the default signing identity? This could be a problem for some applications. If it wasn't intentional, then you can add optional keyChain and signingInfo parameters to FullProducer and PartialProducer. Alternatively, if PSync is restricted to the default KeyChain and SigningInfo, I think this should be mentioned in the class description.

Back