Project

General

Profile

Actions

Feature #4837

closed

Allow optional KeyChain and SigningInfo

Added by Anonymous about 5 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
02/06/2019
Due date:
% Done:

0%

Estimated time:

Description

In ProducerBase, the m_segmentPublisher is initialized with a default KeyChain. The constructor does not allow the caller to specify the KeyChain or the SigningInfo.
https://github.com/named-data/PSync/blob/0cf4b600e91455ee07c38eb22876aa6b653bc14b/PSync/producer-base.cpp#L48

Also, SegmentPublisher::publish has an optional signingInfo parameter, but this is never used.
https://github.com/named-data/PSync/blob/e5fdcc3744d3787949aec0ef23ba9fc8a7db4572/PSync/segment-publisher.hpp#L58

Did you intend to hardwire PSync to only be able to use the default signing identity? This could be a problem for some applications. If it wasn't intentional, then you can add optional keyChain and signingInfo parameters to FullProducer and PartialProducer. Alternatively, if PSync is restricted to the default KeyChain and SigningInfo, I think this should be mentioned in the class description.

Actions #1

Updated by Anonymous about 5 years ago

  • Description updated (diff)
Actions #2

Updated by Junxiao Shi 3 months ago

  • Tracker changed from Task to Feature
  • Status changed from New to Closed

This feature is already in place in mainline codebase.

Actions

Also available in: Atom PDF