Bug #5139
Updated by Ashlesh Gawande over 3 years ago
Regression was introduced in #5009 (https://gerrit.named-data.net/c/NLSR/+/5745/11/src/hello-protocol.cpp). Due to conflicting if and else: [1](https://github.com/named-data/NLSR/blob/0af4627ad73ac9c785154a6410c093dfedcb66f1/src/hello-protocol.cpp#L164) (1)[https://github.com/named-data/NLSR/blob/0af4627ad73ac9c785154a6410c093dfedcb66f1/src/hello-protocol.cpp#L164] [2](https://github.com/named-data/NLSR/blob/0af4627ad73ac9c785154a6410c093dfedcb66f1/src/hello-protocol.cpp#L174) (2)[https://github.com/named-data/NLSR/blob/0af4627ad73ac9c785154a6410c093dfedcb66f1/src/hello-protocol.cpp#L174] the neighbor is not marked as INACTIVE. Will need a unit test to stop this from happening in the future. Furthermore, even if this was correct, in Hyperbolic routing mode the routing table calculation is not scheduled so NLSR takes a long time to reflect the status of the neighbor in the FIB.