Project

General

Profile

Actions

Task #1264

closed

LocalControlHeader attributes on Face

Added by Junxiao Shi almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
Faces
Target version:
Start date:
02/17/2014
Due date:
% Done:

100%

Estimated time:
0.50 h

Description

Add properties to Face abstraction to indicate whether LocalControlHeader is enabled on the Face, and which control modules are enabled.


Related issues 1 (0 open1 closed)

Blocks NFD - Task #1210: LocalControlHeader enabler (manager)Closed

Actions
Actions #1

Updated by Junxiao Shi almost 11 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Junxiao Shi almost 11 years ago

  • Subject changed from LocalControlHeader properties on Face to LocalControlHeader attributes on Face
  • Status changed from In Progress to Code review
  • % Done changed from 0 to 70
Actions #3

Updated by Junxiao Shi almost 11 years ago

  • Status changed from Code review to Closed
  • % Done changed from 70 to 100
Actions #4

Updated by Alex Afanasyev almost 11 years ago

  • Status changed from Closed to Feedback

I had to reopen the issue due to discovered bug... with STL on OSX.

Steve reported that the unit test failed and I can confirm that:

the specific error is: ../tests/face/face.cpp:37: error in "LocalControlHeaderEnabled": check face.isLocalControlHeaderEnabled() == false failed [true != false]

After googling I found this: http://lists.cs.uiuc.edu/pipermail/llvmbugs/2013-August/029627.html

Btw. I previously experienced similar problem with std::vector and another algorithm.

Actions #5

Updated by Alex Afanasyev almost 11 years ago

Not sure if this can be fixed by Xcode (or command line tools) update. I thought I'm using the latest ones...

But even if it fixed, should we support "broken" systems?

Update: there is no currently an update with Xcode and I don't know when it will be. For now we unfortunately cannot use std:: operations on std::vector... (other containers seem work). Such a shame on apple...

Can you check if there is equivalent in boost, may be that one will work?

Actions #6

Updated by Junxiao Shi almost 11 years ago

Please report the exact version of OS, compiler, libc++.

Actions #7

Updated by Alex Afanasyev almost 11 years ago

OSX 10.9, compiler: clang++, Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)

Have zero idea how to check version of STL, but it is the one that comes with the latest XCode 5 (or the latest command-line tools, not sure what is bundled with xcode and what is not).

Actions #8

Updated by Junxiao Shi almost 11 years ago

  • Status changed from Feedback to In Progress
  • % Done changed from 100 to 70

I can reproduce the error on OS X 10.9.

Actions #9

Updated by Junxiao Shi almost 11 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 70 to 100
Actions #10

Updated by Junxiao Shi almost 11 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF